This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add configuration option for tag value that indicates squash #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding, a nested struct could be squashed with the
mapstructure:",squash"
struct tag. A similar functionality appears when marshalling JSON into structs, but it is calledinline
instead ofsquash
.Given that a
DecoderConfig
field allows specifying a different name thanmapstructure
for the struct tag, I think users would want to be able to specify a different value to indicate the "squashing" of nested structs.Indeed, such functionality would allow a more satisfactory resolution to spf13/viper #1050. While it remains true that users may specify a struct tag of `mapstructure:",squash", it is sometimes not possible to do this because the structs are not owned by the current package. If this is merged, users will be able to correctly parse configuration that contains foreign types that have nested structs that need to be inlined with something like: