Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"In progress" badge is only shown on course cards when the user is not enrolled in the course #1692

Closed
collinpreston opened this issue Jun 23, 2023 · 2 comments · Fixed by #1756
Assignees
Labels

Comments

@collinpreston
Copy link
Contributor

Steps to Reproduce

  • Setup a program which has two courses associated with it as requirements. Both courses should have course runs with start dates in the past and end dates in the future, and enrollment start dates in the past. Create a program run with a start date in the past and end date in the future.
  • Enroll a user into one of the two courses.
  • View the program drawer.

Expected Behavior

Both course cards should display the "In progress" badge.

Actual Behavior

Only the course card for the course which the user is not enrolled in displays the "In progress" badge.

Screenshot or Screencast

Screenshot 2023-06-23 at 16 27 05

@collinpreston
Copy link
Contributor Author

@pdpinch, I think there was some back and forth on these badges a while back. Do we still want to uphold this functionality or should this bug be closed and another issue created to remove the existence of the "In progress" badge?

@collinpreston collinpreston added bug Something isn't working product:mitx-online labels Jul 12, 2023
@jkachel jkachel self-assigned this Jul 17, 2023
jkachel added a commit that referenced this issue Jul 17, 2023
- Adds In Progress badges everywhere that a course is in progress #1692
- Display program enrollments even if there's no enrollments #1693
- Actually reload the data if we unenroll from something, rather than displaying stale data
@pdpinch
Copy link
Member

pdpinch commented Jul 27, 2023

Thanks for the reminder. I haven't been able to locate the discussion, other than a reference to the cards being "busy" in #884

However, it seems redundant to me to have "In Progress" and "Active" -- don't they mean the same thing? Let's remove them.

What other badges do we have in this context? I'll open an issue to track this.

jkachel added a commit that referenced this issue Jul 28, 2023
* Updates to the dashboard functionality

- ~~Adds In Progress badges everywhere that a course is in progress #1692~~
- Display program enrollments even if there's no enrollments #1693
- Actually reload the data if we unenroll from something, rather than displaying stale data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants