Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgramSerializer should now return default image if there's no program page #1750

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

jkachel
Copy link
Contributor

@jkachel jkachel commented Jul 14, 2023

What are the relevant tickets?

Related to #1738

Description (What does it do?)

If the program doesn't have a page, the frontend will crash because it expects a featured image. This adds a default featured image if there's no page, so it doesn't.

How can this be tested?

  1. Create a new program. (Manually using the Django Admin is the recommended method so you don't inadvertently get a page created or anything.)
  2. Create a program enrollment for one of your accounts.
  3. Log in and navigate to the dashboard.
  4. Click the My Programs page. You should see the new program.

Copy link
Contributor

@collinpreston collinpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jkachel jkachel merged commit 97e4542 into main Jul 14, 2023
3 checks passed
@jkachel jkachel deleted the jkachel/1738-fix-no-images branch July 14, 2023 18:58
@odlbot odlbot mentioned this pull request Jul 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants