Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-2877] Objectives api v2 Pytests #2283

Merged
merged 22 commits into from
Oct 7, 2021

Conversation

bleepbop
Copy link
Contributor

Description

Unit tests for the v2 Objectives API.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Verified that tests pass for multiple versions of python with Tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2283 (55367b7) into master (2b51007) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2283      +/-   ##
==========================================
+ Coverage   72.14%   72.31%   +0.16%     
==========================================
  Files         106      107       +1     
  Lines        7790     7837      +47     
==========================================
+ Hits         5620     5667      +47     
  Misses       2170     2170              
Impacted Files Coverage Δ
app/api/v2/handlers/objective_api.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b51007...55367b7. Read the comment docs.

@bleepbop bleepbop requested a review from uruwhy October 4, 2021 17:13
Copy link
Contributor

@mchan143 mchan143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work with all of these PRs.

@bleepbop bleepbop enabled auto-merge (squash) October 7, 2021 01:29
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bleepbop bleepbop merged commit 75399ca into master Oct 7, 2021
@bleepbop bleepbop deleted the bleepbop/VIRTS-2877/objectives-api-v2-pytest branch October 7, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants