-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ops source fix #2323
Ops source fix #2323
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2323 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 110 110
Lines 7944 7944
=======================================
Hits 5768 5768
Misses 2176 2176 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the fact source selection works via GUI - however, I did just notice that selecting different planners via the GUI doesn't actually work - it just sticks with atomic, according to the operation report output.
…data did not return object ids in some cases)
Thanks--it was because it was trying to send the planner id when creating an operation, but the data passed from the jinja data object didn't have IDs for the planners. The operations page now pulls all information from API/v2 rather than jinja. |
c2b7443
to
f2beda4
Compare
f2beda4
to
de878bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Fixed bug where creating a new operation always defaulted to using 'basic' as the source
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: