Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops source fix #2323

Merged
merged 7 commits into from
Oct 29, 2021
Merged

Ops source fix #2323

merged 7 commits into from
Oct 29, 2021

Conversation

iguannalin
Copy link
Contributor

Description

Fixed bug where creating a new operation always defaulted to using 'basic' as the source

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@iguannalin iguannalin self-assigned this Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #2323 (3b2b624) into master (2aea586) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files         110      110           
  Lines        7944     7944           
=======================================
  Hits         5768     5768           
  Misses       2176     2176           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aea586...3b2b624. Read the comment docs.

Copy link
Contributor

@uruwhy uruwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fact source selection works via GUI - however, I did just notice that selecting different planners via the GUI doesn't actually work - it just sticks with atomic, according to the operation report output.

@iguannalin
Copy link
Contributor Author

Looks like the fact source selection works via GUI - however, I did just notice that selecting different planners via the GUI doesn't actually work - it just sticks with atomic, according to the operation report output.

Thanks--it was because it was trying to send the planner id when creating an operation, but the data passed from the jinja data object didn't have IDs for the planners. The operations page now pulls all information from API/v2 rather than jinja.

Copy link
Contributor

@ArtificialErmine ArtificialErmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@uruwhy uruwhy merged commit 5412ad1 into master Oct 29, 2021
@uruwhy uruwhy deleted the ops-source-fix branch October 29, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants