Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-3040] Fix Timestamp Error in Sources API Tests #2328

Merged

Conversation

bleepbop
Copy link
Contributor

Description

In test_sources_api.py, test_update_source was failing due to differing timestamps. The test has been updated to mock datetime, ensuring that the timestamps will be equal.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Verified tests passed for multiple versions of python with tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop enabled auto-merge (squash) October 21, 2021 18:54
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2328 (2e7be3b) into master (9ab1527) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2328   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files         110      110           
  Lines        7942     7942           
=======================================
  Hits         5768     5768           
  Misses       2174     2174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab1527...2e7be3b. Read the comment docs.

@bleepbop bleepbop merged commit c121153 into master Oct 21, 2021
@bleepbop bleepbop deleted the bleepbop/VIRTS-3040/sources-api-test-timestamp-fixes branch October 21, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants