Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations select dead agent bug in add potential link menu #2344

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

iguannalin
Copy link
Contributor

@iguannalin iguannalin commented Nov 1, 2021

Description

Fixed bug where if first agent is dead, does not let user select a different agent when creating a command
Removed opacity styling on view command buttons in operation links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

…ere if first agent is dead, does not let user select a different agent when creating a command
@iguannalin iguannalin self-assigned this Nov 1, 2021
@iguannalin iguannalin requested review from argaudreau and wbooth and removed request for argaudreau November 1, 2021 15:54
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #2344 (8a9f149) into master (0ba7e82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2344   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files         110      110           
  Lines        7946     7946           
=======================================
  Hits         5769     5769           
  Misses       2177     2177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba7e82...8a9f149. Read the comment docs.

argaudreau
argaudreau previously approved these changes Nov 1, 2021
@argaudreau argaudreau requested review from cyber-arsenull and removed request for wbooth November 9, 2021 22:49
templates/operations.html Outdated Show resolved Hide resolved
Remove unnecessary assignment

Co-authored-by: Jordan Hanna <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iguannalin iguannalin merged commit 514c144 into master Nov 9, 2021
@iguannalin iguannalin deleted the ops-agent-fix branch November 9, 2021 23:48
cyber-arsenull added a commit that referenced this pull request Dec 28, 2021
* Fix opacity for view command buttons in operation links; Fixed bug where if first agent is dead, does not let user select a different agent when creating a command

* Update templates/operations.html

Remove unnecessary assignment

Co-authored-by: Jordan Hanna <[email protected]>

Co-authored-by: Adam Gaudreau <[email protected]>
Co-authored-by: Jordan Hanna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants