Revert profiles.html and rename showAbilityModal.

[cyber-arsenull]

Rename to showAbilityChoiceModal.

Description

PR for bug #2350
Revert of profiles.html as the showAbilityModal was replaced with the one from abilities.html which has a different purpose. Also change name to showAbilityChoiceModal to differentiate and avoid name collisions in Alpine if both tabs are loaded.

Type of change

Please delete options that are not relevant.

• [X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

1. Start adversary
2. Click Add Ability
3. Check if modal appears correctly.

Checklist:

• [X ] My code follows the style guidelines of this project
• [X ] I have performed a self-review of my own code

[codecov]

Codecov Report

Merging #2351 (8bd711f) into master (7cb868d) will increase coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2351      +/-   ##
==========================================
+ Coverage   71.44%   72.60%   +1.15%     
==========================================
  Files         110      110              
  Lines        7634     7946     +312     
==========================================
+ Hits         5454     5769     +315     
+ Misses       2180     2177       -3     

Impacted Files	Coverage Δ
app/contacts/contact_ftp.py	50.95% <0.00%> (-0.33%)	⬇️
app/objects/c_objective.py	100.00% <0.00%> (ø)
app/utility/base_service.py	100.00% <0.00%> (ø)
app/api/v2/handlers/health_api.py	100.00% <0.00%> (ø)
app/objects/secondclass/c_rule.py	100.00% <0.00%> (ø)
app/api/v2/security.py	97.36% <0.00%> (+0.07%)	⬆️
app/objects/secondclass/c_fact.py	98.70% <0.00%> (+0.10%)	⬆️
app/api/v2/managers/base_api_manager.py	96.46% <0.00%> (+0.12%)	⬆️
app/contacts/contact_dns.py	80.59% <0.00%> (+0.13%)	⬆️
app/service/learning_svc.py	87.32% <0.00%> (+0.18%)	⬆️
... and 61 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb868d...8bd711f. Read the comment docs.

[argaudreau]

Other than the small issue with the cleanup commands it looks great! No more errors in the console when I tested it out.

[cyber-arsenull]

Sonarcloud doesn't like using <i> tags, and wants to use <em> tags. However, it only complains about this as a "bug" in two places, eventhough <i> are used in several places.
@argaudreau @wbooth
Preference on resolving that part?

[wbooth]

@cyber-arsenull soanrcloud is checking only "new" code, so I would fix to the standard and then update the others as we go

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication