Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to agents page, add deadman abilities #2354

Merged
merged 10 commits into from
Dec 2, 2021
Merged

Conversation

argaudreau
Copy link
Contributor

Description

This PR adds a feature and fixes a couple of bugs in the Abilities page:

  • Add deadman ability selection to agent configuration
  • Add button to kill all agents
  • Fix "last seen" column tooltip error in Safari
  • Fix agent alive/dead status in Safari

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • All dates show properly in agents page in Safari, Chrome, FF
  • Kill all agents button removes all agents from lists and changes the watchdog and sleep timer values for each
  • Deadman ability selection replicates bootstrap ability selection

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2354 (7ac057d) into master (7404bcd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2354   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files         110      110           
  Lines        7948     7948           
=======================================
  Hits         5782     5782           
  Misses       2166     2166           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7404bcd...7ac057d. Read the comment docs.

@iguannalin
Copy link
Contributor

I think the colors are very helpful, and I love the hover-effect over the # agents button to see it categorized into the agent statuses.
Two questions:

  1. Is it possible to top-align the deadman searchbar to the Deadman Abilities label in the agent modal?
  2. I noticed that when I delete/bulk-delete agents, the verification popup is using the browser's default popup--I can't remember if we've talked about this or not. What do you think about converting those to modals too for consistency?

Screen Shot 2021-11-29 at 16 23 47

Screen Shot 2021-11-29 at 16 23 59

@argaudreau
Copy link
Contributor Author

1. Is it possible to top-align the deadman searchbar to the `Deadman Abilities` label in the agent modal?

Yep! Those are now top aligned.

2. I noticed that when I delete/bulk-delete agents, the verification popup is using the browser's default popup--I can't remember if we've talked about this or not. What do you think about converting those to modals too for consistency?

I've added a confirmation modal for all confirm actions to align with the rest of the site.

iguannalin
iguannalin previously approved these changes Dec 1, 2021
Copy link
Contributor

@iguannalin iguannalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Only one more nit-picky thing that I noticed--the field host_ip_addrs seems to be an array now so the display for that in the agent detail modal (next to 'Host') is an empty parentheses
Screen Shot 2021-11-30 at 19 51 23

Copy link
Contributor

@uruwhy uruwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - played around with some of the features

@wbooth wbooth enabled auto-merge December 2, 2021 16:16
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wbooth wbooth merged commit 07fa1ff into master Dec 2, 2021
@wbooth wbooth deleted the deadman_abilities branch December 2, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants