Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VIRTS-4159] update check reason skipped #2623

Merged
merged 37 commits into from
Aug 21, 2023
Merged

[VIRTS-4159] update check reason skipped #2623

merged 37 commits into from
Aug 21, 2023

Conversation

bleepbop
Copy link
Contributor

@bleepbop bleepbop commented Jul 20, 2022 •
edited
Loading

Description

Creates new Reasons enum within c_operation.py. These Reasons are used by _check_reason_skipped() to determine why operation abilities didn't run. Reasons are ordered by priority, with lower values indicating higher priority.

Dependent on #2612

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Added unit tests for each potential reason an ability would be skipped.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop requested a review from uruwhy July 21, 2022 01:45
@bleepbop bleepbop mentioned this pull request Jul 22, 2022
Merged
5 tasks
uruwhy
uruwhy reviewed Jul 25, 2022
View reviewed changes
app/objects/c_operation.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.4% 97.4% Coverage
0.0% 0.0% Duplication

@mchan143
Copy link
Contributor

@bleepbop any chance you'll have some availability soon to update and make these changes?

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot closed this Sep 12, 2022
@mchan143 mchan143 reopened this Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot closed this Apr 17, 2023
@bleepbop bleepbop reopened this Jun 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot closed this Jul 5, 2023
@clenk clenk reopened this Jul 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@bleepbop bleepbop removed the request for review from elegantmoose August 1, 2023 01:05
@bleepbop bleepbop requested a review from clenk August 11, 2023 20:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

94.1% 94.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

clenk
clenk approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elegantmoose elegantmoose removed the request for review from djlawren August 21, 2023 18:54
@elegantmoose elegantmoose merged commit 3140411 into master Aug 21, 2023
11 checks passed
@elegantmoose elegantmoose deleted the bleepbop/VIRTS-4159/update_check_reason_skipped branch August 21, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uruwhy uruwhy uruwhy left review comments

@elegantmoose elegantmoose elegantmoose approved these changes

@clenk clenk clenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bleepbop @mchan143 @clenk @elegantmoose @uruwhy