Fix command modal for manual commands #2668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When viewing the command for a manual command in an operation, the "Obfuscated" and "Plaintext" command outputs didn't always make sense, even if obfuscation wasn't used. This PR ensures that the command is always accurately displayed, as the user entered it.
Worth noting that we're still aware that
command
andplaintext_command
as returned from the API are always base64 encoded. i.e., if no obfuscation is used,command
andplaintext_command
will be base64 obfuscated, but they will equal each other. When they don't equal each other, it means obfuscation was used. The View Command modal in the UI will always decode those commands for you.Type of change
How Has This Been Tested?
Running a command with an adversary and adding a manual command showed the correct command in the View Command modal each time.
Checklist: