Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tabs to top of page #2695

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Pin tabs to top of page #2695

merged 2 commits into from
Dec 13, 2022

Conversation

argaudreau
Copy link
Contributor

Description

Pins the page tabs to the top of the page so you can switch tabs at any time.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Works on Firefox, Chrome, and Safari -- tabs are always pinned to the top with appropriate padding.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@argaudreau argaudreau requested review from JamieScottC, deacon-mp and a team November 30, 2022 14:53
JamieScottC
JamieScottC approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@JamieScottC JamieScottC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs stay at the top of the page for me!

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@argaudreau argaudreau merged commit 1defd92 into master Dec 13, 2022
@argaudreau argaudreau deleted the pin-tabs branch December 13, 2022 21:22
BuildAndDestroy pushed a commit to BuildAndDestroy/caldera that referenced this pull request Apr 6, 2023
@argaudreau @BuildAndDestroy
Pin tabs to top of page (mitre#2695)
a102ba8
Aledangelo pushed a commit to secureware-srl/caldera that referenced this pull request Apr 28, 2023
@argaudreau @Aledangelo
Pin tabs to top of page (mitre#2695)
894ee5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieScottC JamieScottC JamieScottC approved these changes

@deacon-mp deacon-mp Awaiting requested review from deacon-mp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argaudreau @JamieScottC