Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change moving abilities on adversary dashboard from swap to insert #2770

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

JamieScottC
Copy link
Contributor

Description

This PR changes the functionality of moving abilities on the adversary page. Previously, when dragging and dropping an ability over another ability the two would swap places. Now, the ability is simply inserted below or above where the user is dragging it to. Additionally, when dragging an ability there is now a green bar indicating where it will be placed when dropped.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested multiple adversaries with different numbers of abilities and tested dragging abilities with different starting indices.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! Your first PR -- thanks for contributing!

@JamieScottC JamieScottC marked this pull request as ready for review June 13, 2023 14:59
Copy link
Contributor

@elegantmoose elegantmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elegantmoose elegantmoose merged commit 794039a into master Jun 14, 2023
@elegantmoose elegantmoose deleted the drag-ability branch June 14, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants