Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle origin link ID as string #59

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Handle origin link ID as string #59

merged 3 commits into from
Oct 18, 2021

Conversation

uruwhy
Copy link
Contributor

@uruwhy uruwhy commented Jun 25, 2021 •
edited
Loading

Updating method signatures and agent link ID storage to match UUID format for link ID

Requires mitre/caldera#2187

Addresses origin link ID issue in mitre/caldera#2162

@uruwhy uruwhy self-assigned this Jun 25, 2021
@uruwhy uruwhy mentioned this pull request Jun 25, 2021
Merged
5 tasks
@uruwhy uruwhy requested a review from mchan143 October 13, 2021 18:34
mchan143
mchan143 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@mchan143 mchan143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uruwhy uruwhy merged commit 5e2ce57 into master Oct 18, 2021
@cyber-arsenull cyber-arsenull mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchan143 mchan143 mchan143 approved these changes

Assignees

@uruwhy uruwhy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uruwhy @mchan143