Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build M1 Mac Images #4100

Merged
merged 5 commits into from
Mar 14, 2023
Merged

Build M1 Mac Images #4100

merged 5 commits into from
Mar 14, 2023

Conversation

spencer-cdw
Copy link
Contributor

If you attempt to run this container on an M1 mac, the user will encounter this error

runner-heimdall-lite-1  | 2023/02/20 19:33:36 [emerg] 58#58: io_setup() failed (38: Function not implemented)

There are stackoverflow questions that suggest multiple workarounds, however non are working for me.

It would be nice if a native M1 mac build was provided in addition to the amd64 builds

Additional information

github actions build-push-action buildkit documentation: https://github.com/docker/build-push-action

@Amndeep7
Copy link
Contributor

Thanks for your contribution Spencer. We're doing some research to make sure we can test locally and to ensure we add support properly before we merge this in.

Copy link
Contributor

@Hookwitz Hookwitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested local builds work on M1 mac

@aaronlippold aaronlippold self-requested a review March 13, 2023 22:14
@aaronlippold aaronlippold added the enhancement New feature or request label Mar 13, 2023
@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into master. label Mar 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify mergify bot merged commit d62fb57 into mitre:master Mar 14, 2023
@Amndeep7
Copy link
Contributor

hi @spencer-cdw. i'm going to need to revert this change for now. we are still very interested in having multiplatform builds, but at the moment it's causing the CI to take multiple hours or even timeout entirely while trying to build the images. we're gonna be brainstorming solutions for this (non github workflow based build + upload? change underlying container image again? something you can come up with?), so do expect the functionality to come back.

workflow runs exhibiting problems:

https://github.com/mitre/heimdall2/actions/runs/4568237540/jobs/8063032619

https://github.com/mitre/heimdall2/actions/runs/4568237543/jobs/8063032750

issue tracking multiplatform builds: #4295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants