Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added README for dockerhub #255

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

patrickjcasey
Copy link
Contributor

@patrickjcasey patrickjcasey commented Aug 6, 2024

I added a new folder to the top level of the repo third-party-docs and added README-dockerhub.md file with a README that can be added to mitre/hipcheck page on dockerhub. I am not sure if we want to make another top-level directory, but I did not want to clutter the root of the repository with something that is only for Dockerhub. If anyone has suggested alternatives, please let me know!

I could not find any information for adding/editing the description via any official Docker tooling, but I found this link if we want to add this to CI to be run after deploying the latest image to Dockerhub

As far as adding tags, there did not seem to be an automated way of doing it. This link shows how to adjust the settings for the project and also contains the Categories supported by Dockerhub. I would propose that we add the following tags to the mitre/hipcheck image:

  • Security
  • Integrations & Delivery (if hipcheck is ever designed to be run in CI/CD pipelines)

@patrickjcasey patrickjcasey added the type: chore Clean up or management task. label Aug 6, 2024
@patrickjcasey patrickjcasey self-assigned this Aug 6, 2024
@patrickjcasey patrickjcasey linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@alilleybrinker alilleybrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickjcasey! I have a few nitpick comments that should be quick fixes.

As for the location of the file, I'm inclined to instead name any top-level folder with files necessary for distributing Hipcheck something like dist/. This would keep with the generally short naming convention of other top-level folders. Within that folder, it would probably be good to split up the content based on the use, so putting it at dist/dockerhub/README.md would make sense.

Regarding the Category topic, I've pinged Amndeep to see if he can set the "Security" category for us.

third-party-docs/README-dockerhub.md Outdated Show resolved Hide resolved
third-party-docs/README-dockerhub.md Outdated Show resolved Hide resolved
third-party-docs/README-dockerhub.md Outdated Show resolved Hide resolved
@alilleybrinker
Copy link
Collaborator

Oh, and we probably should just use this GitHub Action (https://github.com/peter-evans/dockerhub-description) for setting the description. Under the hood it uses a Docker Hub API token to make the relevant API call for setting the description. This way we can update it ourselves whenever we need to instead of needing to ping Amndeep.

@patrickjcasey patrickjcasey force-pushed the patrickjcasey/dockerhub-readme branch 2 times, most recently from 4de4b6d to 1118561 Compare August 6, 2024 19:16
@patrickjcasey
Copy link
Contributor Author

I preliminarily added the job to CI to automatically update the description. I don't think there is a way to test it works without actually pushing something to dockerhub. Also, I was not 100% certain that dockerhub credentials are the same as the credentials used for the docker cli

@patrickjcasey
Copy link
Contributor Author

Also it should be noted somewhere that dockerhub limits the description to 25,000 bytes and the github-action plugin we are using automatically performs the truncation if necessary

@alilleybrinker
Copy link
Collaborator

Also it should be noted somewhere that dockerhub limits the description to 25,000 bytes and the github-action plugin we are using automatically performs the truncation if necessary

Good to note. We probably ought to error out rather than silently truncating. Likely means checking the byte length ourselves.

@patrickjcasey patrickjcasey marked this pull request as ready for review August 9, 2024 12:38
@alilleybrinker alilleybrinker merged commit 10130df into main Aug 9, 2024
6 checks passed
@alilleybrinker
Copy link
Collaborator

Thanks @patrickjcasey! 🎉

@patrickjcasey patrickjcasey deleted the patrickjcasey/dockerhub-readme branch August 22, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Clean up or management task.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Docker deploy to include an overview and tags
2 participants