fix quiet bug regression #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding testing, we've talked about doing snapshot testing with |
patrickjcasey
requested review from
a team,
cstepanian and
alilleybrinker
and removed request for
a team
patrickjcasey
force-pushed
the
patrickjcasey/quiet-flag-bug
branch
from
e1b87ea
to
d4a9374
Compare
alilleybrinker
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
hc check --format json -v quiet https://github.com/mitre/hipcheck, the following error occurs onorigin/mainHere is the tip of
origin/mainwith the policy file error omittedThe tip of this branch has nothing printed before the JSON is output
If anyone has an idea of how to test this/ensure I hid everything that should be hidden when
-v quietis passed, I would love to hear it!