fix: Broken release build for Hipcheck. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out Cargo doesn't like when materials required to build a crate are outside of the crate manifest directory. In this case, I'm talking about the protobuf definition used for the Hipcheck plugin gRPC service. There's a Cargo issue open about it, but the gist of it is that they don't really want people doing what we were trying to do, having materials in an outer directory. There may be better solutions, but moving the files is the fastest one for now. Here's the issue: rust-lang/cargo#3946 Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out Cargo doesn't like when materials required to build a crate are outside of the crate manifest directory. In this case, I'm talking about the protobuf definition used for the Hipcheck plugin gRPC service.
There's a Cargo issue open about it, but the gist of it is that they don't really want people doing what we were trying to do, having materials in an outer directory.
There may be better solutions, but moving the files is the fastest one for now.
Here's the issue: rust-lang/cargo#3946