Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert 'cargo-dist' workaround #372

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

alilleybrinker
Copy link
Collaborator

We hit a bug in 'cargo-dist' yesterday that it turns out was already fixed in the latest version, but before we figured that out we implemented a workaround to enable us to get 3.6.2 out the door. Now that we know the latest 'cargo-dist' version doesn't need the workaround, we can revert it and use 0.22.1.

@alilleybrinker alilleybrinker added the type: chore Clean up or management task. label Sep 10, 2024
@alilleybrinker alilleybrinker added this to the 3.6.0 milestone Sep 10, 2024
@alilleybrinker alilleybrinker self-assigned this Sep 10, 2024
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/revert-dist-workaround branch from 3e3120c to f659def Compare September 10, 2024 14:01
We hit a bug in 'cargo-dist' yesterday that it turns out was already fixed in
the latest version, but before we figured that out we implemented a
workaround to enable us to get 3.6.2 out the door. Now that we know the
latest 'cargo-dist' version doesn't need the workaround, we can revert it
and use 0.22.1.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/revert-dist-workaround branch from f659def to 3a048ca Compare September 10, 2024 14:07
@alilleybrinker
Copy link
Collaborator Author

Haha the plan step saved me multiple times here, catching errors that would have broken my release!

@mchernicoff mchernicoff merged commit fbb958e into main Sep 10, 2024
6 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/revert-dist-workaround branch September 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Clean up or management task.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants