chore: Removes module analysis, data path, and scripts folder #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchernicoff
requested review from
patrickjcasey
and removed request for
a team
alilleybrinker
requested changes
Sep 10, 2024
Oh good catch. |
mchernicoff
force-pushed
the
mchernicoff/delete-scripts
branch
from
06d5ee9
to
1047485
Compare
alilleybrinker
requested changes
Sep 10, 2024
…n and scripts folder
mchernicoff
force-pushed
the
mchernicoff/delete-scripts
branch
from
1047485
to
8418777
Compare
alilleybrinker
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the module analysis and any of its dependent code. Because the
module-deps.jsonfile is no longer needed, this also removes any code, including in the CLI, related to specifying or locating the "data folder." And this removes the extraneousscriptsfolder, which resolves #350 .