Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update devcontainer definition #417

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

alilleybrinker
Copy link
Collaborator

This commit does two things:

  • Removes module-deps as an NPM dependency, since we no longer need/use it.
  • Adds protobuf-compiler as an Apt dependency, since we need it to build our gRPC server definition.

This commit does two things:

- Removes `module-deps` as an NPM dependency, since we no longer
  need/use it.
- Adds `protobuf-compiler` as an Apt dependency, since we need it to
  build our gRPC server definition.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker added the type: bug Something isn't working label Sep 17, 2024
@alilleybrinker alilleybrinker added this to the 3.7.0 milestone Sep 17, 2024
@alilleybrinker alilleybrinker requested a review from a team September 17, 2024 17:25
@alilleybrinker alilleybrinker self-assigned this Sep 17, 2024
@alilleybrinker alilleybrinker requested review from cstepanian and removed request for a team September 17, 2024 17:25
@alilleybrinker alilleybrinker added the product: project Relates to the project itself label Sep 17, 2024
@mchernicoff mchernicoff merged commit 32ae9d0 into main Sep 17, 2024
6 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/update-devcontainer branch September 19, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: project Relates to the project itself type: bug Something isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants