Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds datetime and span primitives to the policy expression syntax #419

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat: Adds datetime and span primitives to the policy expression syntax #419

merged 1 commit into from
Sep 18, 2024

Conversation

mchernicoff
Copy link
Contributor

Resolves Issue #400. Adds Datetime and Span types to the Primitives used in the policy expression syntax. Operators that use these types and an RFD explaining their intend use will be added in future commits.

@mchernicoff mchernicoff added type: enhancement New feature or request product: rust-sdk Relates to the Rust plugin SDK product: project Relates to the project itself labels Sep 18, 2024
@mchernicoff mchernicoff added this to the 3.7.0 milestone Sep 18, 2024
@mchernicoff mchernicoff requested review from alilleybrinker and a team September 18, 2024 12:27
@mchernicoff mchernicoff self-assigned this Sep 18, 2024
@j-lanson j-lanson added product: hc Relates to the core "hc" binary and removed product: rust-sdk Relates to the Rust plugin SDK product: project Relates to the project itself labels Sep 18, 2024
@mchernicoff mchernicoff force-pushed the mchernicoff/datetime-policy-expressions branch from e7af2c3 to e96788b Compare September 18, 2024 15:42
@mchernicoff
Copy link
Contributor Author

Looks like some tests are failing now, including ones unrelated to datetime and span. May have to do with the changes to the error type.

@j-lanson
Copy link
Collaborator

Looks like some tests are failing now, including ones unrelated to datetime and span. May have to do with the changes to the error type.

Failures seem related to adding ' to regex for ident primitive

@mchernicoff mchernicoff force-pushed the mchernicoff/datetime-policy-expressions branch from 73fe2f7 to 36356e9 Compare September 18, 2024 17:13
@mchernicoff mchernicoff marked this pull request as ready for review September 18, 2024 17:14
@j-lanson j-lanson self-requested a review September 18, 2024 17:14
j-lanson
j-lanson approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@j-lanson j-lanson merged commit 58c57e2 into main Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-lanson j-lanson j-lanson approved these changes

@alilleybrinker alilleybrinker Awaiting requested review from alilleybrinker

Assignees

@mchernicoff mchernicoff

Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Projects
Hipcheck Dev Roadmap
Status: Done
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mchernicoff @j-lanson