emasser Docker Build Fix #1080

georgedias · 2023-02-05T21:11:28Z

dependabot was changing the inquire and inquirer-file-tree-selection-prompt

Version above the listed here do not support CommonJs modules.
required fixed versions are:
"inquirer": "8.0.0",
"inquirer-file-tree-selection-prompt": "1.0.19"

How to test - ERROR

Clone the master repo
On the root directory of the repo Build the Docker package
a. docker build -t safdockerbuildtest:latest .
Run the newly created image:
a. docker run s safdockerbuildtest:latest

It should fail due to the wrong inquirer-file-tree-selection-prompt being used

How to test -FIX

Clone the emass_clientDependencies repo
On the root directory of the repo Build the Docker package
a. docker build -t safdockerbuildtest:latest .
Run the newly created image:
a. docker run s safdockerbuildtest:latest

It should run with the previous error
Additional test run:
docker run safdockerbuildtest:latest emasser version

NOTE

Make sure docker is running
If the build errors executing the yarn command yarn --frozen-lockfile --production --network-timeout 600000, comment line 17 on the Dockerfile
If the build errors executing the bash jq curl ca-certificates, comment line 26 on the Dockerfile

mergify · 2023-02-07T02:18:17Z

This pull request has a conflict. Could you fix it @georgedias?

Amndeep7 · 2023-02-08T02:49:09Z

Was able to duplicate the issue you had. Your fix made it so that the command would run, but it's still not working properly. For some reason, at the very first prompt when i run emasser configure it doesn't let me put in any characters and then immediately exits the application.

Win10, wsl -> ubuntu

@georgedias
The configure (generate a .env config file) capability does not work when deploying via docker. I will have to note that on the documentation. If you deploy via executables you will see that it works. The main issue being resolved by the PR was the inability of deploying saf via docker due to the dependency miss-match, that was fixed.

I don't think we can fix the issue as it is imbedded within the inquirer package and not how we are implementing the capabilities provided by the package.