Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to use aws-sdk v3 #1182

Merged
merged 5 commits into from
Dec 6, 2023
Merged

updated to use aws-sdk v3 #1182

merged 5 commits into from
Dec 6, 2023

Conversation

Amndeep7
Copy link
Contributor

@Amndeep7 Amndeep7 commented Mar 9, 2023 •
edited
Loading

In order to get rid of that obnoxious warning, we still need to update hdf-converters and oclif itself

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@spencer-cdw
Copy link
Contributor

I am looking forward to this fix. This warning clutters up the CI logs, it would be really nice to not have this message show up anymore.

(node:48840) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)

@aaronlippold aaronlippold added enhancement New feature or request Usability labels Mar 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This pull request has a conflict. Could you fix it @Amndeep7?

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

This pull request has a conflict. Could you fix it @Amndeep7?

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

This pull request has a conflict. Could you fix it @Amndeep7?

@Amndeep7
merge in main
cf5f9ed 
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
dealing with @smithy transition and merged in latest aws-v3-compatibl…
61c824c 
…e-hdf-converters

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7 Amndeep7 marked this pull request as ready for review December 6, 2023 18:34
@Amndeep7
overwrite nodejs version cache when it's not the latest version accor…
cdf7224 
…ding to that semver range described

Signed-off-by: Amndeep Singh Mann <[email protected]>
@aaronlippold aaronlippold merged commit 47a91c7 into main Dec 6, 2023
4 of 10 checks passed
@mergify mergify bot deleted the upgrade_to_aws-sdk-v3 branch December 6, 2023 19:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlippold aaronlippold aaronlippold approved these changes

Assignees

@Amndeep7 Amndeep7

Labels
enhancement New feature or request Usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amndeep7 @spencer-cdw @aaronlippold