Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug found for SAF CLI convert hdf2ckl command #1205

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Fixes bug found for SAF CLI convert hdf2ckl command #1205

merged 2 commits into from
Apr 20, 2023

Conversation

Hookwitz
Copy link
Contributor

set vid that maps to Vuln_Num to use tags.gid if available otherwise use control id

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hookwitz Hookwitz linked an issue Mar 16, 2023 that may be closed by this pull request
[BUG] saf convert hdf2ckl produces invalid CKL files #1074
Closed
@Hookwitz Hookwitz removed a link to an issue Mar 16, 2023
[BUG] saf convert hdf2ckl produces invalid CKL files #1074
Closed
@rlakey rlakey linked an issue Apr 3, 2023 that may be closed by this pull request
Generating Checklist with convert hdf2ckl does not produce a valid CKL file in 1.2.7 #1238
Closed
@aaronlippold aaronlippold added bug Something isn't working enhancement New feature or request Community Contribution labels Apr 7, 2023
@em-c-rod
Copy link
Contributor

em-c-rod commented Apr 7, 2023

I think this needs confirmation by @ejaronne

ejaronne
ejaronne approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@ejaronne ejaronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mitre/heimdall2#4212 (comment)
LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hookwitz Hookwitz merged commit c29eba8 into main Apr 20, 2023
@mergify mergify bot deleted the ckl-export-vuln-num-bug branch April 20, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejaronne ejaronne ejaronne approved these changes

@aaronlippold aaronlippold Awaiting requested review from aaronlippold

@Amndeep7 Amndeep7 Awaiting requested review from Amndeep7

@em-c-rod em-c-rod Awaiting requested review from em-c-rod

Assignees

@Amndeep7 Amndeep7

@em-c-rod em-c-rod

Labels
bug Something isn't working Community Contribution enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating Checklist with convert hdf2ckl does not produce a valid CKL file in 1.2.7
5 participants
@Hookwitz @em-c-rod @ejaronne @aaronlippold @Amndeep7