Added GPR publishing #1209
Merged
Added GPR publishing #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amndeep7
requested changes
Mar 16, 2023
|
|
||
| # Publish SAF CLI to GitHub Package Registry | ||
| - name: Publish SAF CLI to GPR | ||
| run: npm publish mitre-saf-v*.tgz |
There was a problem hiding this comment.
"When publishing scoped packages, the access level defaults to restricted. If you want your scoped package to be publicly viewable (and installable) set --access=public." - https://docs.npmjs.com/cli/v8/commands/npm-publish#access
idk why we need --access public for the npm one since it doesn't have that scope input, but shouldn't this publish call have it then?
georgedias
commented
Mar 16, 2023
Amndeep7
requested changes
Mar 16, 2023
georgedias
commented
Mar 17, 2023
Amndeep7
requested changes
Mar 17, 2023
Amndeep7
requested changes
Mar 18, 2023
Signed-off-by: George Dias <[email protected]>
Amndeep7
approved these changes
Mar 21, 2023
Amndeep7
added
the
ready-to-merge
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change workflow name to include action (from push-to-npm.yml to push-to-npm-gpr.yml)
Add the publishing to GitHub Package Registry (GPR)