Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yq to the image #1250

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Add yq to the image #1250

merged 3 commits into from
Apr 13, 2023

Conversation

spencer-cdw
Copy link
Contributor

@spencer-cdw spencer-cdw commented Mar 24, 2023 •
edited
Loading

Related to:

Issues:
#1246
#1247

PRs:
#1249

By adding yq to the stock image, it is possible to do parsing on the threshold.yml file as part of a github actions.

saf generate threshold -i inspec.json -c --output /tmp/foobar 2>/dev/null; cat /tmp/foobar | yq .error

@spencer-cdw spencer-cdw mentioned this pull request Mar 24, 2023
Open
@spencer-cdw
Copy link
Contributor Author

Tested manually. Confirmed that yq is available on stock node:16-alpine image

docker run -it node:16-alpine /bin/sh  
/ # apk add jq
fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/main/aarch64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/community/aarch64/APKINDEX.tar.gz
(1/2) Installing oniguruma (6.9.8-r0)
(2/2) Installing jq (1.6-r2)
Executing busybox-1.35.0-r29.trigger
OK: 11 MiB in 19 packages
/ # apk add yq
(1/1) Installing yq (4.30.4-r2)
Executing busybox-1.35.0-r29.trigger
OK: 20 MiB in 20 packages

@em-c-rod em-c-rod added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Apr 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify mergify bot merged commit 6e20af4 into mitre:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em-c-rod em-c-rod em-c-rod approved these changes

Assignees

@aaronlippold aaronlippold

@em-c-rod em-c-rod

@wdower wdower

Labels
Community Contribution enhancement New feature or request ready-to-merge Used by mergify to identify if a PR is ready to merge into main.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencer-cdw @em-c-rod @aaronlippold @wdower