CLI support for Microsoft SecureScore report conversion #2742

meme112233 · 2024-07-22T20:41:28Z

CLI support for converting Microsoft SecureScore reprots to OHDF format.

Mapping support provided via mitre/heimdall2#6007

This provides 2 modes of operation:

conversion from pre-downlaoded REST endpoint files
conversion after CLI downloads from REST endpoints using supplied creds

# edit and source this file to load credentials
export TENANT="<TENANT_ID>"
export APP="<APP_ID>"
export SECRET="<APP_SECRET>"

./bin/run convert msftSecureScore2hdf -t "$TENANT" -a "$APP"  -s "$SECRET"  -o <OUT_FILE>

src/commands/convert/msftSecureScore2hdf.ts

src/commands/convert/index.ts

src/commands/convert/msftSecureScore2hdf.ts

Co-authored-by: Charles Hu <[email protected]>

…xit gracefully

Signed-off-by: Charles Hu <[email protected]>

README.md

src/commands/convert/index.ts

src/commands/convert/msft_secure2hdf.ts

…st convert msft_secure

Co-authored-by: Amndeep Singh Mann <[email protected]>

meme112233 · 2024-07-30T21:33:14Z

Per comment, added an input option -i which consists of the exact file input format as the mapper.

src/commands/convert/msft_secure2hdf.ts

src/commands/convert/index.ts

mergify · 2024-08-05T22:10:56Z

This pull request has a conflict. Could you fix it @meme112233?

README.md

src/commands/convert/msft_secure2hdf.ts

Co-authored-by: Amndeep Singh Mann <[email protected]>

Signed-off-by: Amndeep Singh Mann <[email protected]>

…e mapper and also modified the test so that it could find the generated files (was expecting just the -o parameter but it also always adds some other info to the filepath) and modified the test so that it would match the data structures properly Signed-off-by: Amndeep Singh Mann <[email protected]>

Signed-off-by: Amndeep Singh Mann <[email protected]>

sonarcloud · 2024-08-07T03:45:05Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

meme112233 added 5 commits July 19, 2024 17:31

initial commit

6ddeed6

fix comments copy-pasta issues/add feature pull from Msft Graph API

e0b1afa

fix required/optional params

b9b506b

bugfix/Graph API read response comes in as object

c540050

lint fix

79b6558

charleshu-8 assigned meme112233 Jul 23, 2024

charleshu-8 added the enhancement New feature or request label Jul 23, 2024

update package-lock.json

f444a28

charleshu-8 reviewed Jul 24, 2024

View reviewed changes

meme112233 and others added 11 commits July 24, 2024 15:09

commit for external testing change of secureScore API read

0441cb9

remove unused imports in msftSecureScore2hdf.ts

6beed05

Co-authored-by: Charles Hu <[email protected]>

rename converter command to msft_secure2hdf, update cli flags docs, e…

5a9012d

…xit gracefully

Merge remote-tracking branch 'origin/meme-working' into meme-working

a5d3a35

update usage string

44ef860

update flags to reflect Microsoft terminology

a180a50

pass with-raw parameter to msft_secure2hdf

c4694f1

implement SecureScore converter in the generic command

268a78b

add unit test

3d0319a

Clean up

6b89156

Signed-off-by: Charles Hu <[email protected]>

Clean up import

6e44b0f

Signed-off-by: Charles Hu <[email protected]>

Amndeep7 requested changes Jul 29, 2024

View reviewed changes

meme112233 and others added 9 commits July 29, 2024 15:57

handle pagination of SecureScoreControlProfile

a5de165

update cli conversion flags to be mutually exclusive and inter-dependent

dcd6949

update usage string in accordance with POSIX format

06aa80d

update README usage. add msft_secure to convert/index.ts. add unit te…

b1aa946

…st convert msft_secure

update README, bugfix test, update usage

69d7d53

Update README.md

cc76a91

Co-authored-by: Amndeep Singh Mann <[email protected]>

revert formatting changes to commands/convert/index.ts

1e7be9d

update usage, description, and examples msft_secure2hdf.ts

c3a0ffd

README formatting cleanup

9eb02c2

msft_secure2hdf adds -i option for combined input (mapper input format)

0e8e189

draft of passing TLS insecure and CA flags to msft_secure2hdf

dfd903a

Amndeep7 requested changes Jul 31, 2024

View reviewed changes

src/commands/convert/msft_secure2hdf.ts Show resolved Hide resolved

src/commands/convert/index.ts Outdated Show resolved Hide resolved

mitre deleted a comment from JH-Klevin Aug 5, 2024

meme112233 added 2 commits August 6, 2024 11:32

merge from master

55bb750

output multiple hdf reports by secureScore.id as name

2147d26

Amndeep7 requested changes Aug 6, 2024

View reviewed changes

meme112233 and others added 15 commits August 6, 2024 14:45

handle null auxData

906b35b

Co-authored-by: Amndeep Singh Mann <[email protected]>

Update README.md

cfbb9be

Co-authored-by: Amndeep Singh Mann <[email protected]>

Update README.md

3b92650

Co-authored-by: Amndeep Singh Mann <[email protected]>

Update README.md

402619d

Co-authored-by: Amndeep Singh Mann <[email protected]>

update function signature any->void

3c0bbdc

expand msft -> Microsoft README.md

5c0ea35

cleanup README.md

982cf0e

cleanup README.md

e675819

update README.md annotate file types and cmds to acquire

52bbe1c

Update src/commands/convert/msft_secure2hdf.ts

6e002e1

Co-authored-by: Amndeep Singh Mann <[email protected]>

README cleanup

18066b5

fix linting and Typescript pedantic typing challenges

9683a78

use latest heimdall release which includes the securescore mapper

295feb2

Signed-off-by: Amndeep Singh Mann <[email protected]>

fix deepsource complaints

71b8a40

Signed-off-by: Amndeep Singh Mann <[email protected]>

Amndeep7 approved these changes Aug 7, 2024

View reviewed changes

Amndeep7 merged commit 55cce0b into main Aug 7, 2024
12 of 13 checks passed

Amndeep7 deleted the meme-working branch August 7, 2024 03:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI support for Microsoft SecureScore report conversion #2742

CLI support for Microsoft SecureScore report conversion #2742

meme112233 commented Jul 22, 2024

meme112233 commented Jul 30, 2024

mergify bot commented Aug 5, 2024

sonarcloud bot commented Aug 7, 2024

CLI support for Microsoft SecureScore report conversion #2742

CLI support for Microsoft SecureScore report conversion #2742

Conversation

meme112233 commented Jul 22, 2024

meme112233 commented Jul 30, 2024

mergify bot commented Aug 5, 2024

sonarcloud bot commented Aug 7, 2024

Quality Gate passed