Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved getLocalIPv4Addresses() to agent_util.go in mitre/gocat to prev… #353

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

raviserota
Copy link
Contributor

@raviserota raviserota commented Feb 26, 2021

…ent code duplication, since this function is needed by agent.go as well. Call to this function in the edited file has been updated accordingly.

Description

Adding local IP address fetching function to sandcat. This is one 1/4 pull requests, in addition to:

mitre/gocat#48
mitre/caldera#2056
A yet-to-be-created fieldmanual PR.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Agent IP address functionality is working on my local system. Proxy functionality has not yet been tested to unsure it hasn't been broken.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation

…ent code duplication, since this function is needed by agent.go as well. Call to this function in the edited file has been updated accordingly.
Copy link
Contributor

@unkempthenry unkempthenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on mitre/gocat#48

@unkempthenry unkempthenry assigned wbooth and unassigned unkempthenry Mar 4, 2021
@wbooth wbooth merged commit 8b5f5f5 into master Mar 9, 2021
@wbooth wbooth deleted the virts-1801-agent-ip-addresses branch March 9, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants