Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Filters constructible from IntoIterators #400

Closed
wants to merge 2 commits into from
Closed

Make Filters constructible from IntoIterators #400

wants to merge 2 commits into from

Conversation

david-perez
Copy link

This just relaxes bounds. Useful to create filters from arrays.

@david-perez
Make Filters constructible from IntoIterators
1ba939b 
This just relaxes bounds. Useful to create filters from arrays.
@mitsuhiko
Copy link
Owner

I am in favor of this change, but I'm a bit worried about now having a generic T implementation there. It might be okay, but then it cannot be implemented for potentially other things in the future. I will think about this change a bit more.

@mitsuhiko mitsuhiko added the enhancement New feature or request label Oct 8, 2023
@david-perez
Copy link
Author

Ah yeah you're right. I've pushed a commit to implement FromIterator instead. I've also restored the From<Vec<(&'a str, &'a str)>> implementation, since removing it is a breaking change, but there shouldn't be a need for it if we have FromIterator.

@mitsuhiko mitsuhiko mentioned this pull request Nov 5, 2023
Closed
@mitsuhiko
Copy link
Owner

Applied in 1d70238

@mitsuhiko mitsuhiko closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-perez @mitsuhiko