Upgrade to syn 2 #517
Merged
Upgrade to syn 2 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
commented
Jul 7, 2024
| @@ -19,8 +19,8 @@ console = "0.15.4" | |||
| structopt = { version = "0.3.26", default-features = false } | |||
| serde = { version = "1.0.117", features = ["derive"] } | |||
| serde_json = "1.0.59" | |||
| proc-macro2 = { version = "1.0.24", features = ["span-locations"] } | |||
| syn = { version = "1.0.50", features = ["full", "visit", "extra-traits"] } | |||
| proc-macro2 = { version = "1.0.60", features = ["span-locations"] } | |||
There was a problem hiding this comment.
Required because of rust-lang/rust#113152
Need to upgrade structopt and then we'll reduce the compile time.
|
@mitsuhiko if you're looking for one or two PRs to review, this is at the bottom of a fairly long stack of changes. You can also say "no need to ask a review here", or "this one you didn't wait for a review and I would have liked to review it" so we can calibrate... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to upgrade
structoptand then we'll reduce the compile time by coalescing on a singlesynEdit: possibly we need to wait for a newer MSRVReady to merge