Add cargo.lock, use cargo-msrv to verify MSRV
#524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does a few things: - Adds `Cargo.lock` to the repo. Maybe others have different opinions; though it is [now recommended](rust-lang/cargo@3bb02f2#diff-3388c611c3bcae8ef4efe0ec5c9f5e22682b0db86c9e7137e70e5ba7d5e456c0R11), and it solves a bunch of the issues around `Cargo.lock.msrv`, closing mitsuhiko#498. Without this, the remainder of this PR isn't feasible in its current state. - Uses `cargo-msrv` to verify the MSRV specs in the `Cargo.toml` files in CI, simplifying CI jobs - Adds 1.61.0 as the MSRV for `cargo-insta` - Bumps the MSRV for `insta` to 1.57.0, from 1.51.0, allowing us to remove some of the hacks around named profiles. This was released Dec 2021.
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Jul 7, 2024
Currently when I run `cargo update && cargo build` locally, I get failures around `similar 2.5.0`. I'm not sure why CI has been passing; this is a test to check whether it's the cache which is holding an existing version of dependencies. mitsuhiko#524 adds the lockfile to the repo, which would reduce the change of a local dev break
This was referenced Jul 7, 2024
max-sixty
commented
Jul 9, 2024
max-sixty
changed the title
cargo-msrv to verify MSRVcargo.lock, use cargo-msrv to verify MSRV
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does a few things:
Cargo.lockto the repo. Maybe others have different opinions; though it is now recommended, and it solves a bunch of the issues aroundCargo.lock.msrv, closingCargo.lock.msrvis outdated and missing packages #498. Without this, the remainder of this PR isn't feasible in its current state.cargo-msrvto verify the MSRV specs in theCargo.tomlfiles in CI, simplifying CI jobscargo-instainstato 1.57.0, from 1.51.0, allowing us to remove some of the hacks around named profiles. 1.57.0 was released Dec 2021.