Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_runner in config #544

Merged
merged 32 commits into from
Aug 2, 2024

Conversation

max-sixty
Copy link
Collaborator

This was previously ignored.

Stacks on #521 to avoid conflicts; merge that first

Still need to finish this off, one test fails.

`structopt` was build on clap 2, and then its features were integrated into clap 3. So it's not actually a heavier dependency. May have to check on MSRV issues.

Once we merge this, we only have one version of `syn`, which reduces our dependency size significantly.
Need to upgrade structopt and then we'll reduce the compile time.
This was previously ignored.

Stacks on mitsuhiko#521 to avoid conflicts; merge that first
max-sixty added a commit to max-sixty/insta that referenced this pull request Jul 31, 2024
This allows a project to default to `nextest` in its insta config, while falling back to `cargo test` when that isn't available.

Stacks on mitsuhiko#544

Needs an integration test, will add when mitsuhiko#537 merges
@mitsuhiko mitsuhiko merged commit 527aed7 into mitsuhiko:master Aug 2, 2024
15 checks passed
@max-sixty max-sixty deleted the tool-config-test-runner branch August 2, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants