implement a split filter
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
reviewed
Jun 4, 2024
minijinja/src/filters.rs
Outdated
| @@ -557,6 +557,23 @@ mod builtins { | |||
| } | |||
| } | |||
|
|
|||
| /// Split a string with a separator | |||
mitsuhiko
requested changes
Jun 4, 2024
minijinja/src/filters.rs
Outdated
| @@ -557,6 +557,23 @@ mod builtins { | |||
| } | |||
| } | |||
|
|
|||
| /// Split a string with a separator | |||
| #[cfg_attr(docsrs, doc(cfg(feature = "builtins")))] | |||
| pub fn split(val: Value, split: Option<Cow<'_, str>>) -> Result<Value, Error> { | |||
There was a problem hiding this comment.
I would change this filter in two ways so it's similar to the .split function in Python:
- if
Noneor an empty string is passed (or nothing at all), it splits on any whitespace (split_whitespace). - a second parameter (
nsplits) is added which indicates how many times the string is to be split.1means one split (eg: two parts),2means two splits (eg: three parts).
There was a problem hiding this comment.
Alright - yeah, I was looking for your input before continuing. Sounds like a plan!
mitsuhiko
reviewed
Jun 4, 2024
minijinja/src/filters.rs
Outdated
|
|
||
| match val.as_str() { | ||
| Some(s) => { | ||
| let elements = s.split(split).map(Value::from).collect::<Vec<Value>>(); |
There was a problem hiding this comment.
This could be returned as iterable rather than collected into a Vec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's kinda useful, especially as a counterpart to
join.