-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 2 compatibility and redis fixes. #9
base: master
Are you sure you want to change the base?
Conversation
You have to squash them when you merge it in. I don't have merge permission. |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 84.57% 84.41% -0.16%
==========================================
Files 12 12
Lines 350 385 +35
==========================================
+ Hits 296 325 +29
- Misses 54 60 +6
Continue to review full report at Codecov.
|
Variablize config options.
Should resolve #3 now, this threw me off for a moment as well. |
Should probably note this will break old configurations. Config needs to be updated to: celery_app.config_from_object({ Config using celeryconfig.py obj::
|
Hi! I've close reviewed your changes and write some comments. It should be fixed before I can merge your changes. Also some changes have to be made too:
|
Fixed - Issue where it would attempt to import redis in the store/redis.py overlapping naming...
Fixed - super() calls.
Fixed - An issue where py2 didn't like the class being the same type as renamed parent. Hence BeatXScheduler rename.
Fixed - Import urllib urlparse.
Fixed - Travis CI for Py2
Added - mock requirement for Py2
Added - Uppercase config detection, resolves #3.