Add iframe as element to not consider blank #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, please add
Please revert the test. Currently there are no tests for these blank elements, so I don't think it's strictly necessary to test them at the moment. Thanks! |
mojoLyon
force-pushed
the
fix/212-specials-tags-not-blank
branch
from
00f84fc
to
919f5c1
Compare
mojoLyon
force-pushed
the
fix/212-specials-tags-not-blank
branch
from
919f5c1
to
5cd8277
Compare
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I add script tag too to be able to close the #212 issue ?
May be I don't update the good test , let me know if I must correct this :)