Fix browser modules export. Fixes domchristie/turndown#334. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michbart
force-pushed
the
fix-browser-modules-export
branch
from
6c43e0a
to
8d71a2d
Compare
|
Review OK + verified that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes
browserfield exported by Turndown'spackage.json.Motivation behind this PR:
I'm using Turndown as a dependency in another project and when I build
umdpackage with Rollup.js, Turndown with JSDOM is included and there is no elegant way to replace it except modifying browser field. After thatrollup/plugin-node-resolvecan use the module exported bybrowserfield when building my project.