Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make survey prompt optional via metadata flag #290

Closed
wants to merge 1 commit into from

Conversation

grendell
Copy link

Currently in the Mixpanel SDK for iOS, there is no prompt before the user is shown a survey. We would like to replicate this on Android. The intention of this change is to allow this to be configurable via a metadata tag in the app manifest, falling back to current behavior if this tag is not present.

Example usage:

    <meta-data
        android:name="com.mixpanel.android.MPConfig.ShouldPromptForSurvey"
        android:value="false"/>

If there is a more appropriate place for this flag, please let me know.

@grendell
Copy link
Author

Also, if there are any instructions for how to compile mixpanel-android locally, I have run into major issues both attempting to export an AAR and creating a submodule in our app, using Android Studio 1.5 and gradle 1.5.0. The AAR appears to be incomplete, while compiling the submodule leads to OOMs which I can't seem to solve with studio.vmoptions.

@grendell
Copy link
Author

grendell commented Feb 8, 2016

Updated based on feedback from #283.

@patedit patedit closed this Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants