Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SecureRandom instead of Random #697

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Conversation

mohalaci
Copy link
Contributor

Please use SecureRandom instead of Random because security analyzer tools mark mixpanel as an un-secure library.

Copy link
Contributor

@patedit patedit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've added a quick comment. I'll merge this to master as soon as it's addressed. Thanks a lot for the contribution!

@zihejia zihejia merged commit 8446c4f into mixpanel:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants