Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit exported flag to activities #755

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Add explicit exported flag to activities #755

merged 1 commit into from
Oct 7, 2021

Conversation

headsvk
Copy link
Contributor

@headsvk headsvk commented Sep 20, 2021

Hi, we updated our app to target Android 12 and get the following error when running connected tests:

android:exported needs to be explicitly specified for . Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

I looked into merged manifests and found out it was Mixpanel causing this issue so I opened this pull request 🙂

@zihejia zihejia self-requested a review October 7, 2021 18:12
zihejia
zihejia approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @headsvk!

@zihejia zihejia merged commit 3995cd3 into mixpanel:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headsvk @zihejia