Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating 'People.identify' and merge it into 'MixpanelAPI.identify' #781

Merged
merged 10 commits into from
May 5, 2022

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented Mar 8, 2022

This PR is to merge People.identify into MixpanelAPI.identify an effort to make it in parity with Mixpanel's iOS and JS SDK. Going forward, calling People.identify is no longer recommended, please use MixpanelAPI.identify() and set 'usePeople' to true instead

@zihejia zihejia changed the title Merge identity Merge identify Mar 8, 2022
@zihejia zihejia changed the title Merge identify Deprecating 'People.identify' and merge it into 'MixpanelAPI.identify' Mar 10, 2022
Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zihejia zihejia merged commit 33f4f92 into master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants