Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for Autotrack setting #794

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for Autotrack setting #794

merged 4 commits into from
Aug 16, 2022

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented Jul 13, 2022 •
edited
Loading

Since this PR, we are deprecating the Automatically collect common mobile events
setting from Mixpanel website in favor of reducing crashes and race conditions when collecting common mobile events.

image

Alternatively, you need to specify a new param trackAutomaticEvents in getInstance as belows:

...
* @param trackAutomaticEvents Whether or not to collect common mobile events
*                             include app sessions, first app opens, app updated, etc.
...
public static MixpanelAPI getInstance(Context context, String token, boolean trackAutomaticEvents)
public static MixpanelAPI getInstance(Context context, String token, boolean optOutTrackingDefault, boolean trackAutomaticEvents)
public static MixpanelAPI getInstance(Context context, String token, boolean optOutTrackingDefault, String instanceName, boolean trackAutomaticEvents)
public static MixpanelAPI getInstance(Context context, String token, JSONObject superProperties, boolean trackAutomaticEvents)
public static MixpanelAPI getInstance(Context context, String token, JSONObject superProperties, String instanceName, boolean trackAutomaticEvents)
public static MixpanelAPI getInstance(Context context, String token, boolean optOutTrackingDefault, JSONObject superProperties, String instanceName, boolean trackAutomaticEvents)

@zihejia zihejia changed the title remove decide api check &make track automatic events a required param remove decide api check & make track automatic events a required param Jul 13, 2022
@zihejia zihejia force-pushed the zihe-deprecate-decide branch 3 times, most recently from d951590 to 17f7f73 Compare July 13, 2022 20:22
@zihejia zihejia changed the title remove decide api check & make track automatic events a required param Remove decide api check & make track automatic events a required param Jul 13, 2022
@zihejia zihejia changed the title Remove decide api check & make track automatic events a required param Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for this setting Jul 13, 2022
@zihejia zihejia changed the title Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for this setting Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for Autotrack setting Jul 13, 2022
@zihejia zihejia changed the title Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for Autotrack setting Add 'trackAutomaticEvents' as a required param in getInstance' and remove Mixpanel server api call for Autotrack setting Jul 13, 2022
jaredmixpanel
jaredmixpanel approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zihejia zihejia force-pushed the zihe-deprecate-decide branch 2 times, most recently from 595f7c6 to fe1ef66 Compare July 13, 2022 23:57
@zihejia zihejia force-pushed the zihe-deprecate-decide branch 2 times, most recently from c6667c7 to f01ee41 Compare August 4, 2022 00:36
@jaredmixpanel jaredmixpanel merged commit 87eb182 into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmixpanel jaredmixpanel jaredmixpanel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zihejia @jaredmixpanel