app extension now uses main ios target. uses bundle identifier to che… #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarneo
approved these changes
Oct 18, 2017
…ck if is app extension, and hides UIApplication sharedApplication behind perform selector to avoid compile errors. should maintain same functionality as before for app extension
pchien
force-pushed
the
consolidate-app-extension
branch
from
c7c1796
to
f93ec7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ck if is app extension, and hides UIApplication sharedApplication behind perform selector to avoid compile errors. should maintain same functionality as before for app extension
this should be pretty much the same as what swift did mixpanel/mixpanel-swift#92