Remove semaphores, copy properties, use .merging, don't includeLibInfo in init #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
properties
object passed toinitialize()
contains both the lib metadata (i.e.mp_lib
and$lib_version
) and the user specified super properties: https://github.com/mixpanel/mixpanel-react-native/blob/master/index.js#L67That object is then passed to the native initialize method as the
superProperties
param to be registered prior to all event tracking (so there is no need toincludeLibInfo
when we process the properties: https://github.com/mixpanel/mixpanel-react-native/blob/master/ios/MixpanelReactNative.swift#L25Additionally, make a copy of the
properties
dictionary to be passed tosetAutomaticProperties
. So that it is not the same value that is passed toprocessProperties
and use native.merging()
method to create a new dictionary instead of using custom mutatingmerge
function.Because the lib properties are registered as super properties upon initialization, we do not need to
includeLibInfo
when we calltrack
ortrackWithGroups
, only people calls will need them.