Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mixpanel type conversion for ios #48

Merged
merged 1 commit into from
May 7, 2021
Merged

fix mixpanel type conversion for ios #48

merged 1 commit into from
May 7, 2021

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented May 7, 2021 •
edited
Loading

Fix the issue where in some cases property value in an array of string type or dictionary type can't be tracked properly.

@zihejia zihejia requested a review from jaredmixpanel May 7, 2021 17:28
jaredmixpanel
jaredmixpanel approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zihejia zihejia merged commit f040855 into master May 7, 2021
@torufuruya torufuruya mentioned this pull request May 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmixpanel jaredmixpanel jaredmixpanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zihejia @jaredmixpanel