Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass completion handler to flush on background #542

Merged
merged 4 commits into from
May 5, 2022
Merged

pass completion handler to flush on background #542

merged 4 commits into from
May 5, 2022

Conversation

jaredmixpanel
Copy link
Contributor

@jaredmixpanel jaredmixpanel commented May 4, 2022 •
edited
Loading

This should hopefully fix: mixpanel/mixpanel-react-native#132

@jaredmixpanel jaredmixpanel requested a review from zihejia May 4, 2022 23:14
@jaredmixpanel jaredmixpanel changed the title pass handler to flush on background pass completion handler to flush on background May 4, 2022
zihejia
zihejia approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zihejia zihejia mentioned this pull request May 5, 2022
Merged
@jaredmixpanel jaredmixpanel merged commit cf549d8 into master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@jaredmixpanel @zihejia