SkinLoader: Avoid detach of Qt container in range loop

mixxxdj · May 22, 2021 · 3ba5bb4 · 3ba5bb4
1 parent afc00bf
commit 3ba5bb4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/skin/skinloader.cpp b/src/skin/skinloader.cpp
@@ -30,7 +30,8 @@ QList<Skin> SkinLoader::getSkins() const {
     const QList<QDir> skinSearchPaths = getSkinSearchPaths();
     QList<Skin> skins;
     for (const QDir& dir : skinSearchPaths) {
-        for (const QFileInfo& fileInfo : dir.entryInfoList(QDir::Dirs | QDir::NoDotAndDotDot)) {
+        const QList<QFileInfo> fileInfos = dir.entryInfoList(QDir::Dirs | QDir::NoDotAndDotDot);
+        for (const QFileInfo& fileInfo : fileInfos) {
             QDir skinDir(fileInfo.absoluteFilePath());
             if (skinDir.exists(QStringLiteral("skin.xml"))) {
                 skins.append(Skin(fileInfo));