-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark first of every four bars of beatgrid #10164
Comments
Commented by: fkbreitl |
Commented by: ronso0
|
Commented by: fkbreitl Has there been any progress in the last months? |
Commented by: Be-ing Not much progress. Yes this is important, but it's actually a huge project, not a simple task. |
Commented by: fkbreitl Well I was looking at the code and thinking that if one could just change the color, width or length of every forth bar, it would already be very helpful in most cases. |
Commented by: fkbreitl @jan No, I was not talking about the PR. I don't even understand what it is about. |
Commented by: fkbreitl Aha, but these PRs seem much more sophisticated than what I had proposed. |
Commented by: fkbreitl I think done is better than perfect. Without colors it is much more difficult to keep the orientation in a track. |
Commented by: Holzhaus
IIRC we once had a test build that just marked every 4th beat in a different color, and to my knowledge the testers found that more confusing then helpful because in many cases that beat was not the Downbeat. Hence, you'd also need editing capabilites, too. When you have editing capabilities, you need to store that data, which requires a protobuf format changes and a migration of all existing user beatmap/beatgrid data. This also makes it impossible to downgrade to an earlier version of Mixxx without losing all your beatgrids. Therefore, we should design the protobuf format properly to not do more backwards-incompatible changes than needed. |
Commented by: fkbreitl Sounds good to me. |
Commented by: fkbreitl Side comment: If storing additional information breaks backward compatibility you might want to consider a redesign of the storing method. To my understanding only one additional integer is needed to determine which of the first four bars it is (1, 2, 3 or 4). |
Commented by: Be-ing The problem is that Mixxx has two separate, incompatible methods of storing beat data. This needs to be fixed before changing the stored data format. |
Commented by: fkbreitl Would this be an opportunity to move to the rekordbox format? |
Commented by: Holzhaus
First, we need to merge the disjunct BeatMap/BeatGrid classes. I'm already working on that right now. Then we can evaluate what the best storage format would be. I'm not sure that Rekordbox's storage format (documented here: https://djl-analysis.deepsymmetry.org/rekordbox-export-analysis/anlz.html#beat-grid) is really the best way to store such data. I personally find Serato's format (documented here: https://github.com/Holzhaus/serato-tags/blob/master/docs/serato_beatgrid.md#beatgrid-markers) simpler and easier to extend. But first we need to refactor because the two classes duplicate all work that needs to be done. |
Commented by: fkbreitl The rekordbox format might not be the best format but still the best choice, because it is most widely used, the de facto standard and safest choice for the future. |
Commented by: fkbreitl Hi! Has there been any progress on this feature in recent months? |
Commented by: daschuer No progress recently. Do you have interest to pick some of this work up? |
Not sure if this has been expressed explicitly yet: it'd be great if it were not limited to 4 bars but could be switched to 16, 32 & 64 too! |
Reported by: fkbreitl
Date: 2020-10-14T10:03:02Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1899759
Tags: beatgrid, usability
Attachments: [Rekordbox screenshot](https://bugs.launchpad.net/bugs/1899759/+attachment/5422252/+files/Rekordbox screenshot)
Rekordbox marks the first of every four bars of the beatgrid with a red marker.
This is very helpful for aligning tracks.
It would be nice to have the same in Mixxx.
The text was updated successfully, but these errors were encountered: