Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple beat grid on a single track #13308

Open
acolombier opened this issue May 31, 2024 · 3 comments · May be fixed by #13330
Open

Multiple beat grid on a single track #13308

acolombier opened this issue May 31, 2024 · 3 comments · May be fixed by #13330

Comments

@acolombier
Copy link
Member

acolombier commented May 31, 2024

Feature Description

It would be great to be able to set multiple grid offsets on a single track. This would allow keeping the grid align with the beat when there is a tempo change. or a missing beat

Currently, using variable BPM, it often happens that the grid ends up off by half a bit on one of tempo.

It would be great to be able to add grid marker to help adjusting the generated beat grid, which is usually only off by a certain offset.

Relates to #10811 and partially #10164

@Swiftb0y
Copy link
Member

@acolombier
Copy link
Member Author

The GSoC/PR related to this stream is a beast... Anything simpler we could consider instead?

@ronso0 ronso0 added the beatgrid label Jun 1, 2024
@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 1, 2024

Not sure, I mean there is #12343 which is much more reduced in scope, but it only addresses the downbeat feature request, not your variable BPM grid request. IIUC the underlying infrastructure is there (src/track/beats.h), it "just" needs to be hooked up and tested. Not sure how much is salvageable from #2961. Then there is also #2930. I was linking that thread mostly not to suggest to adopt that work but instead to provide context to the previous discussion around this so we don't start yet another design process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants