Alt-F Crash fix #11328
Alt-F Crash fix #11328
Conversation
|
Debugging does not reveal anything. It turns out hat the stored pointer in the actions is a QPointer that cannot become dangling. |
| @@ -1438,14 +1440,13 @@ void MixxxMainWindow::slotViewFullScreen(bool toggle) { | |||
| // Fix for "No menu bar with ubuntu unity in full screen mode" Bug | |||
| // #885890 and Bug #1076789. Before touching anything here, please read | |||
| // those bugs. | |||
| QApplication::setAttribute(Qt::AA_DontUseNativeMenuBar, true); | |||
There was a problem hiding this comment.
In my tests I did exactly that (just at the beginning of createMenuBar() depending on isFullScreen(), not directly before the call) and I did set it in main.cpp, not in mixxx.cpp.
So I wonder how that makes the difference...
Anyway, crash fixed!
|
Great, that does the trick 🎉 Crash fixed on Ubuntu 20.04.5 with xfce + vala-appmenu-plugin |
|
Cool, so we can merge this? |
This can easily be combined with #11313 (we can remove the hotkey popup) which fixes the issue with identical fullscreen shortcuts in OS and Mixxx. Thank you for looking into this! |
|
FWIW still hitting the debug assert on shutdown because of leaked controls. |
|
Is this related to this PR? Which one is leaked? |
|
Unrelated, this happens every time after recreating the menubar. |
| QApplication::setAttribute( | ||
| Qt::AA_DontUseNativeMenuBar, | ||
| args.getStartInFullscreen() || fullscreenPref); | ||
| #endif // __LINUX__ |
There was a problem hiding this comment.
Note for future improvements:
it looks like this attribute is the only way to figure whether a platform uses native menus, so let's note the initial state before setting it. That way we could restrict recreating and reconnecting the menu to platforms that actually require/support it.
All Anyway, that's no regression. Thank you very much for digging! |
I'm about to add/refine the related comments. |
|
|
Thank you. I have cherry picked the linked commit. |
This PR does not use the probably broken broken QMenuBar::setNativeMenuBar(false) call.
Even though I still cannot reproduce the issue. It is obvious from the backtrace in #11320 that there is an issue that happens after
deleting the platformMenuBar here: https://github.com/qt/qtbase/blob/8c47a86eecd286dbe66ca55ed4deaaf0f901d13b/src/widgets/widgets/qmenubar.cpp#L1882
I assume that the final crash happens than here:
https://github.com/qt/qtbase/blob/8c47a86eecd286dbe66ca55ed4deaaf0f901d13b/src/widgets/widgets/qmenubar.cpp#L1767
because of a dangling pointer in the sub-menu actions.
It is still a puzzling why the crash does not happen here. At least all is still working tested on Linux Mint Mate, Ubuntu Unity and Ubuntu Desktop.
I will now single step through the code to discover the issue.
@ronso0 I hope this PR gives us the freedom to consider the best solution in your pending work without the fear of a crash.
Can you confirm the crash is fixed?